Skip to content

refactor(cli|exceptions): small update and clean up #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2025

Conversation

spencer-tb
Copy link
Contributor

πŸ—’οΈ Description

Primarily splits up exceptions.py into exceptions/, with no changes to code only a restructure:

exceptions/
β”œβ”€β”€ __init__.py
β”œβ”€β”€ base.py
β”œβ”€β”€ block.py
β”œβ”€β”€ eof.py
β”œβ”€β”€ transaction.py
└── types.py

Additionally removes EOF exceptions from all clients minus evmone. These are simply copied over from evmone's exception so are pointless now. The aim is to reduce some bloat here.

Please comment with any other clean up suggestions.

πŸ”— Related Issues

Requires #1784 to be rebased onto this PR or once in main.

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@spencer-tb spencer-tb added type:refactor Type: Refactor scope:cli Scope: Changes to `ethereum_clis` scope:exceptions Scope: ethereum_test_exceptions package labels Jun 25, 2025
@spencer-tb spencer-tb changed the title Smol exceptions refactor refactor(cli|exceptions): small update and clean up Jun 25, 2025
@spencer-tb spencer-tb requested review from marioevz and danceratopz and removed request for marioevz June 25, 2025 14:32
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit d5f545f into main Jun 25, 2025
27 checks passed
@marioevz marioevz deleted the smol-exceptions-refactor branch June 25, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:cli Scope: Changes to `ethereum_clis` scope:exceptions Scope: ethereum_test_exceptions package type:refactor Type: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants