Skip to content

chore(fw): get weld-ready w/minor fixes to remove dead code #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Carsons-Eels
Copy link

@Carsons-Eels Carsons-Eels commented Jul 1, 2025

πŸ—’οΈ Description

Remove some method params which were not being used.

πŸ”— Related Issues or PRs

Related to The Weld, testing the waters for applying Vulture to EEST.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@codeofcarson codeofcarson force-pushed the minor_dead_code_fixes branch 2 times, most recently from e2ed639 to a5717f1 Compare July 1, 2025 09:52
@codeofcarson codeofcarson force-pushed the minor_dead_code_fixes branch from a5717f1 to dcddb73 Compare July 1, 2025 09:54
@danceratopz danceratopz changed the title Weld: Minor fixes to remove dead code chore(fw): get weld-ready w/minor fixes to remove dead code Jul 1, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I only didn't merge because it's marked as draft, but we should be able to merge once you say it's ready :)

@Carsons-Eels
Copy link
Author

I'll wrap it up and make it live then!

@Carsons-Eels Carsons-Eels marked this pull request as ready for review July 2, 2025 22:19
@codeofcarson codeofcarson closed this by deleting the head repository Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants