- 
                Notifications
    You must be signed in to change notification settings 
- Fork 369
fix(docs): Add workflows and tox envs for building docs #1659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: forks/osaka
Are you sure you want to change the base?
fix(docs): Add workflows and tox envs for building docs #1659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave this a quick look and left some comments, thanks!
41cc805    to
    1f58577      
    Compare
  
    | 
 Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@               Coverage Diff               @@
##           forks/osaka    #1659      +/-   ##
===============================================
+ Coverage        86.07%   86.08%   +0.01%     
===============================================
  Files              743      743              
  Lines            44078    44072       -6     
  Branches          3894     3891       -3     
===============================================
  Hits             37938    37938              
+ Misses            5659     5656       -3     
+ Partials           481      478       -3     
 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
| After #1654 is merged, will need to find-replace  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some smol comments. Can re-evaluate once the weld has progressed.
Maybe we should change eest to ethereum-testing or testing @danceratopz
ethereum#1659) Add a worst-case test running a block with many `ADDMOD` or `MULMOD` instructions with arguments of the parametrized range.
c77fdd3    to
    896fe96      
    Compare
  
    5752b8a    to
    b44fa53      
    Compare
  
    Co-authored-by: danceratopz <[email protected]>
… touch up whitelist, clean up tox
4d6eb1e    to
    ae6a28f      
    Compare
  
    c9881cd    to
    ea111a2      
    Compare
  
    | It was all working, then I rebased onto the latest forks/osaka and it broke again 🤦♀️ | 
| 
 As I understood,  | 
🗒️ Description
WELDs the documentation infrastructure from EEST into the project including automated workflows, tox environments, and tooling to maintain documentation quality.
Key Changes
GitHub Workflows:
.github/workflows/eest-docs.yamlworkflow to automatically build and validate EEST documentation on push and pull request eventspackages/tests/**,tests/**, and the workflow file itselfTox Environments:
changelog: Validates EEST changelog entriesmkdocs: Builds EEST documentation using mkdocs with strict mode enabledmarkdownlint: Lints markdown files using markdownlintcheck-docs: Runs all EEST documentation checksspec-docs: Generate documentation for the specification code using doccDocumentation Tooling:
src/ethereum_spec_tools/whitelist.py: Python script to manage the codespell whitelist with proper alphabetical sorting and formatting.markdownlint.yaml: Configuration for markdownlint with appropriate rule customizationswhitelist.txt: Consolidated EEST's whitelist into ours, cleaned up codespell whitelist entriesdocs/templates/function_parameter_datatable.html.j2: Jinja2 template for rendering function parameter documentationConfiguration Updates:
tox.iniwith new documentation environments and proper dependenciesmkdocstrings[python], etc.) to documentation extrasBenefits
Usage
🔗 Related Issues or PRs
Part of the WELD milestone (❄️ WELD Freeze ❄️)
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e statictype(scope):.mkdocs servelocallyand verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned@ported_frommarker.:::with the new package pathswhitelist word1 word2)Cute Animal Picture
Credit to Linnaea Mallette:
License: CC0 Public Domain