Skip to content

Conversation

@danceratopz
Copy link
Member

@danceratopz danceratopz commented Oct 27, 2025

🗒️ Description

tldr

  1. Fix testing package by adding ruff as a dep (required by gentest).
  2. Move developer dependencies from "extras" (optional dependencies) to PEP 753 "dependency groups".

What changes?

Developers need to run:

uv sync

to get all dev dependencies (previously it was uv sync --all-extras).

More Background

These changes follow a retroactive review of #1671, sorry, I was too slow @fselmo!

I think the standard way of adding dev dependencies is not as an "extra", but rather as a dependency-group:

uv reads development dependencies from the [dependency-groups] table (as defined in PEP 735).

The dev group is special-cased and synced by default.
From https://docs.astral.sh/uv/concepts/projects/sync/#syncing-development-dependencies

So this PR makes that change and additionally removes tox as a direct dev dependency; imo, it should be ran as a "tool" via uvx; the doc changes already made in

reflect that.

Before this PR:

uv sync --extras dev  # unnecessary
uv run tox -e static  # feels a bit weird

With this PR:

uv sync  # installs dev deps by default
uvx tox -e static  # treat tox as a tool

It's great that we get to drop the --with=tox-uv flag!

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md. skipped
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

image

@danceratopz danceratopz added the A-deps Area: Dependencies—Stuff we build on top of (eg. `uv.lock`, `pyproject.toml`) label Oct 27, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (abd7612) to head (bd5dbd3).
⚠️ Report is 3 commits behind head on forks/osaka.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           forks/osaka    #1688   +/-   ##
============================================
  Coverage        86.07%   86.07%           
============================================
  Files              743      743           
  Lines            44078    44078           
  Branches          3894     3894           
============================================
  Hits             37938    37938           
  Misses            5659     5659           
  Partials           481      481           
Flag Coverage Δ
unittests 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danceratopz
Copy link
Member Author

@fselmo @SamWilsn let me know if you like it, I can make a follow-up to update the docs.

Copy link
Member Author

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed up a packaging bug in testing that cropped up due to these changes; it was missing ruff as a dependency.

Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once CI passes 👍🏼

@danceratopz
Copy link
Member Author

lgtm once CI passes 👍🏼

Thanks, now we're failing testing unit tests (here) due to the issue that @felix314159 is addressing here

@fselmo
Copy link
Contributor

fselmo commented Oct 29, 2025

Yep sounds good on CI fix in separate PR if you're good with it 👍🏼

@danceratopz danceratopz merged commit 3d638d9 into ethereum:forks/osaka Oct 30, 2025
16 of 19 checks passed
danceratopz added a commit to danceratopz/execution-specs that referenced this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-deps Area: Dependencies—Stuff we build on top of (eg. `uv.lock`, `pyproject.toml`)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants