Skip to content

Conversation

@pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Oct 28, 2025

πŸ—’οΈ Description

This particular CREATE/2 OOG behavior differs between Frontier and subsequent forks. A simple test (sourced from evmone unittests) handles this case

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@pdobacz pdobacz force-pushed the tests/create-deposit-oog branch from eae8af1 to 8ede4f3 Compare October 28, 2025 13:33
SLOT_CREATE_RESULT_PRE = 0xDEADBEEF


@pytest.mark.valid_from("Frontier")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelent

@spencer-tb spencer-tb added A-test-tests Area: tests for execution spec tests C-enhance Category: an improvement or new feature labels Oct 29, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 86.07%. Comparing base (15b5cfd) to head (cee94e2).
⚠️ Report is 12 commits behind head on forks/osaka.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           forks/osaka    #1705   +/-   ##
============================================
  Coverage        86.07%   86.07%           
============================================
  Files              743      743           
  Lines            44078    44078           
  Branches          3894     3894           
============================================
  Hits             37938    37938           
  Misses            5659     5659           
  Partials           481      481           
Flag Coverage Ξ”
unittests 86.07% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marioevz marioevz merged commit f6cdd1a into ethereum:forks/osaka Oct 31, 2025
8 of 9 checks passed
@pdobacz pdobacz deleted the tests/create-deposit-oog branch October 31, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-tests Area: tests for execution spec tests C-enhance Category: an improvement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants