fix(testing): restore default gas after fill pytester test
#1718
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danceratopz
added
C-bug
8 tasks
SamWilsn
pushed a commit
to SamWilsn/eth1.0-specs
that referenced
this pull request
Oct 30, 2025
…ems (ethereum#1718) * fix: move unit test * Create Enums - Incomplete/broken attempt * fix(filler/checklist): Template copying bug * fix: EIPChecklist usage * docs: Update usage * refactor(eip_checklist): Remove new_* from all IDs * fix: tox (minus spellcheck) * fix: typing * fix(docs,checklists): Rename section to be more descriptive * docs: remove references to string EIP checklist notation * docs: backtick `EIPChecklist` instances * docs: update changelog * docs: fix title * fix(checklists): allow ommission of parentheses in checklist markers * style(checklists): add stubs to solve mypy issues using checklist markers * test(checkmarks): add fw tests that apply EIPChecklists in pytest.param * fix(docs): fix bad links to exception tests * fix(checklists): update test markers to use correct checklist IDs Update test files to use the correct checklist IDs that match the template: - Change 'new_precompile' prefix to 'precompile' - This fixes mkdocs build warnings about missing checklist items The checklist template uses 'precompile/test/*' IDs but tests were using 'new_precompile/test/*' IDs, causing template lookup failures during documentation generation. Also add missing docstrings to fix linting errors. --------- Co-authored-by: danceratopz <[email protected]>
marioevz
changed the title
fill pytester testfill pytester test
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1718 +/- ##
============================================
Coverage 86.07% 86.07%
============================================
Files 743 743
Lines 44078 44078
Branches 3894 3894
============================================
Hits 37938 37938
Misses 5659 5659
Partials 481 481
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danceratopz
changed the title
fill pytester testfill pytester test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
A suggestion how to fix the race condition observed in
packages/testingunit tests, cf #1711.The error described in #1711 can be reproduced on master by running the two tests in this order:
cd packages/testing uv run pytest \ src/execution_testing/cli/pytest_commands/plugins/filler/tests/test_filler.py::test_fill_variables[higher-gas-limit] \ src/execution_testing/test_types/tests/test_types.py::test_model_copy[Environment]🔗 Related Issues or PRs
#1711
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.All: Considered adding an entry to CHANGELOG.md.skippedCute Animal Picture