Skip to content

chore(tests): fix pre alloc phase for deposit test #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2025
Merged

chore(tests): fix pre alloc phase for deposit test #1749

merged 2 commits into from
Nov 4, 2025

Conversation

@spencer-tb
Copy link
Contributor

@spencer-tb spencer-tb commented Nov 4, 2025 •
edited
Loading

🗒️ Description

Fix for: https://github.com/ethereum/execution-specs/actions/runs/19069271240/job/54467602752
Caused by: #1693

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks: 
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@spencer-tb spencer-tb added C-chore Category: chore A-test-tests Area: tests for execution spec tests labels Nov 4, 2025
@spencer-tb spencer-tb force-pushed the fix/pre-alloc-fill-phase-deposit-test branch from 687b935 to 8891d13 Compare November 4, 2025 14:21
@spencer-tb spencer-tb force-pushed the fix/pre-alloc-fill-phase-deposit-test branch from 8891d13 to 1cf39ab Compare November 4, 2025 14:24
@spencer-tb spencer-tb changed the title chore(tests): fix pre alloc phase for deposit test chore(test-tests): fix pre alloc phase for deposit test Nov 4, 2025
@danceratopz danceratopz changed the title chore(test-tests): fix pre alloc phase for deposit test chore(tests): fix pre alloc phase for deposit test Nov 4, 2025
danceratopz
danceratopz approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fselmo fselmo added C-bug Category: this is a bug, deviation, or other problem C-chore Category: chore and removed C-chore Category: chore C-bug Category: this is a bug, deviation, or other problem labels Nov 4, 2025
fselmo
fselmo approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

@fselmo fselmo merged commit 0d95113 into ethereum:forks/osaka Nov 4, 2025
7 of 8 checks passed
chetna-mittal pushed a commit to gnosischain/execution-specs that referenced this pull request Nov 8, 2025
@danceratopz @marioevz @fselmo
chore(tooling): add CLAUDE.md (ethereum#1749)
d6d0c45 
Co-authored-by: Mario Vega <[email protected]>
Co-authored-by: felipe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fselmo fselmo fselmo approved these changes

@danceratopz danceratopz danceratopz approved these changes

Assignees

No one assigned

Labels

A-test-tests Area: tests for execution spec tests C-chore Category: chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spencer-tb @fselmo @danceratopz