Skip to content

Use resolver and driver db in language server #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 21, 2025
Merged

Use resolver and driver db in language server #1104

merged 4 commits into from
Jul 21, 2025

Conversation

micahscopes
Copy link
Collaborator

(please merge #1103 and #1102 first)

resolves #1075

  • Uses the resolver as is instead of all that workspace sync stuff
  • Removes the language server salsa db, instead implementing diagnostics functionality on top of the driver db

@micahscopes micahscopes force-pushed the delete-language-server-workspace branch from 58c1db5 to acbf222 Compare July 15, 2025 19:29
g-r-a-n-t
g-r-a-n-t reviewed Jul 15, 2025
View reviewed changes
@micahscopes micahscopes force-pushed the delete-language-server-workspace branch from acbf222 to 0278892 Compare July 18, 2025 16:25
@micahscopes micahscopes force-pushed the delete-language-server-workspace branch from 0278892 to 6bb1cac Compare July 18, 2025 17:10
@micahscopes micahscopes force-pushed the delete-language-server-workspace branch from 6bb1cac to e5a0cf8 Compare July 18, 2025 17:12
@micahscopes micahscopes requested a review from g-r-a-n-t July 19, 2025 23:35
g-r-a-n-t
g-r-a-n-t approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@g-r-a-n-t g-r-a-n-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@micahscopes micahscopes merged commit 37a7438 into ethereum:master Jul 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-r-a-n-t g-r-a-n-t g-r-a-n-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move ingot loading code from language-server to driver, for use in the fe cli
2 participants
@micahscopes @g-r-a-n-t