Simple local network size estimation #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukasz Foniok <[email protected]>
paulperegud
reviewed
Mar 17, 2017
devp2p/kademlia.py
Outdated
| self.buckets[index] = a | ||
| self.buckets.insert(index + 1, b) | ||
|
|
||
| def getCurrentNetSizeEst(self): |
There was a problem hiding this comment.
This project is using snake_case names for functions instead of camelCase names.
There was a problem hiding this comment.
Please also add a test for this functionality.
Signed-off-by: Lukasz Foniok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple local estimation base on k-buckets, as described here:
https://gnunet.org/sites/default/files/Polot2010.pdf Chapter 5.3
Signed-off-by: Lukasz Foniok [email protected]