Skip to content
This repository was archived by the owner on Dec 10, 2018. It is now read-only.

Remove Hera#24

Open
pirapira wants to merge 1 commit intoethereum:developfrom
pirapira:remove-hera
Open

Remove Hera#24
pirapira wants to merge 1 commit intoethereum:developfrom
pirapira:remove-hera

Conversation

@pirapira
Copy link
Copy Markdown
Member

This might make #9 easier.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 26, 2018

Codecov Report

Merging #24 into develop will increase coverage by 1.13%.
The diff coverage is 82.02%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #24      +/-   ##
===========================================
+ Coverage    71.93%   73.06%   +1.13%     
===========================================
  Files           83       92       +9     
  Lines        10891    12066    +1175     
  Branches      1152     1239      +87     
===========================================
+ Hits          7834     8816     +982     
- Misses        2657     2840     +183     
- Partials       400      410      +10

@pirapira pirapira requested a review from winsvega March 27, 2018 08:46
@winsvega
Copy link
Copy Markdown

winsvega commented Mar 27, 2018

Hera is needed for ewasm support?

@pirapira
Copy link
Copy Markdown
Member Author

@winsvega yes? testeth does not support it.

@winsvega
Copy link
Copy Markdown

it should support compilation of wasm code. axic did a PR to parse it.

@pirapira
Copy link
Copy Markdown
Member Author

@winsvega this repo testeth is not trying to become popular. It's going to disappear anyway (obsoleted by retesteth or merged again into cpp-ethereum). So I'll be removing features before more people start using it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants