refactor: simplify header proof generation #1782
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is first PR that simplifies existing logic before I start adding changes from: #1779
What was wrong?
The code for generating historical_roots and historical_summaries proof is duplicated in a few places.
Some of the utility functions could also be more specific
How was it fixed?
headers_with_proof
and improve tests a bitexecution_block_proof
intoBeaconBlock
BlockBody
HeaderWithProof::proof
matches expected valuebuild_merkle_proof_for_index
genericTo-Do