-
Notifications
You must be signed in to change notification settings - Fork 150
Replace RocksDB with Redb as backing for EVM database #1873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: redb
Are you sure you want to change the base?
Conversation
@owanikin can you fix CI and rebase? |
@owanikin if you need help rebasing or fixing CI just message me on discord and we can jump on a call and fix it quick |
Hi @owanikin github is still reporting a conflict you can fix the conflict by running git fetch upstream
git rebase upstream/master fix the conflicts // don't pull
git push --force |
81a240b
to
751799e
Compare
@owanikin CI is failing again |
751799e
to
5216df3
Compare
Sorry for the late response, as you might be aware of, there were some changes and Trin is no longer actively maintained. Therefore I don't think there is much value in reviewing this entire PR, making sure that everything works as expected, and checking if there are some performance degradation. With that being said, if you don't want all this work to go to waste, I would be fine with creating new branch ( What do you think? |
Thank you @morph-dev , I'll really appreciate that! |
I created new branch and changed the base branch of this PR. Do you mind rebasing your code (to solve conflicts)? |
5216df3
to
74e6749
Compare
Issue #1845
What was wrong?
The client previously used RocksDB for persistent storage of EVM-related data such as accounts, storage slots, block hashes, and contract bytecode. However, RocksDB has several drawbacks for our use case:
How was it fixed?