Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 #63

Open
wants to merge 9 commits into
base: ros2
Choose a base branch
from
Open

ROS2 #63

wants to merge 9 commits into from

Conversation

pascalau
Copy link
Contributor

@pascalau pascalau commented Jan 15, 2023

This PR allows to build the package ros_vrpn in ROS2. This PR has been tested on my side against rolling but it should build against all recent ROS2 releases.

Requirements

  • A ROS2 base install
  • Colcon
  • Colconized vrpn library (vrpn_vendor ros2 branch)
$ mkdir -p ros2_ws/src && cd ros2_ws
# apt install ros-rolling-ros-base ros-dev-tools # ROS repository has to be added beforehand
$ source source /opt/ros/rolling/setup.bash
$ cd src && git clone https://github.com/pascalau/vrpn_catkin.git -b ros2 && cd ..
$ cd src && git clone https://github.com/pascalau/ros_vrpn_client.git -b ros2 && cd ..
$ colcon build --symlink-install

Notable changes:

  • Moved from ROS1 to ROS2
  • Renamed Package to avoid naming collisions for cmake targets
  • Added Linting tests
  • Currently the folder test is not considered in the CMakeLists.txt file
  • Dropped glog dependency since it was previously only used to check for null pointers. Equivalent functionality has been implemented with rclutils.

@rikba
Copy link
Contributor

rikba commented Jan 16, 2023

Also closes #61

@pascalau
Copy link
Contributor Author

I was able to also add the previouly commented Unittests in the test folder.

@pascalau
Copy link
Contributor Author

@clanegge I fixed the observed issue with the timestamps today. The issue was a new behaviour of the .seconds() function as well as numerical issues when calculating only with seconds() precision and not nanoseconds()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants