Update dockerfile and README for ROS 2 and latest tooling #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check dockerfile in CI * Update README for new dockerfile Signed-off-by: Ryan Friedman <[email protected]>
Jaeyoung-Lim
approved these changes
Jan 18, 2024
|
Merge when ready! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the supplied dockerfile to build in the ROS 2 environment. It can be used a base for developers that do not have Ubuntu 22 base OS. I also added a job in CI to test it works which will prevent regressions.
The README also needed a few updates that were missing.
CI was already building in docker, but it didn't use this dockerfile.
Relates to #6