Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor debug logging #138

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Refactor debug logging #138

merged 1 commit into from
Aug 3, 2018

Conversation

etingof
Copy link
Owner

@etingof etingof commented Aug 3, 2018

Debug logging refactored for more efficiency when disabled and for more functionality when in use.

Specifically, the global LOG object can easily be used from any function/method, not just from codec main loop as it used to be.

Debug logging refactored for more efficiency when
disabled and for more functionality when in use.

Specifically, the global LOG object can easily be used
from any function/method, not just from codec main loop
as it used to be.
@codecov-io
Copy link

Codecov Report

Merging #138 into master will increase coverage by 0.07%.
The diff coverage is 88.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   85.67%   85.75%   +0.07%     
==========================================
  Files          29       29              
  Lines        3987     3987              
==========================================
+ Hits         3416     3419       +3     
+ Misses        571      568       -3
Impacted Files Coverage Δ
pyasn1/codec/native/decoder.py 84.84% <100%> (+1.02%) ⬆️
pyasn1/codec/native/encoder.py 87.91% <100%> (+0.81%) ⬆️
pyasn1/codec/ber/encoder.py 90.15% <77.77%> (+0.2%) ⬆️
pyasn1/codec/ber/decoder.py 86.94% <82.85%> (-0.04%) ⬇️
pyasn1/debug.py 94.11% <94.73%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5c3077...88aa4c3. Read the comment docs.

@etingof etingof merged commit a5faeee into master Aug 3, 2018
@etingof etingof deleted the global-debug-object branch October 17, 2018 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants