Add specific exceptions for String issues #155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My application can expect either raw bytes or a string in the same underlying ASN1 components. The current exception hierarchy makes this situation basically impossible to handle.
I have added new exceptions specific to string encoding and decoding, and utilized multiple inheritance to ensure that users catching any relevant type of error will still catch these errors. i.e. users that have updated their code to catch
PyAsn1Error
in this situation can continue doing so unaffected, and users that were already catching theUnicode*Error
s and have not updated will be fixed with this patch.Also worth noting that Python
.encode()
and.decode()
will always use the relevantUnicode*Error
regardless of the passed encoding.