Add SET OF ANY and SEQUENCE OF ANY encoding support
#165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=========================================
- Coverage 85.76% 85.6% -0.16%
=========================================
Files 29 29
Lines 4172 4182 +10
=========================================
+ Hits 3578 3580 +2
- Misses 594 602 +8
Continue to review full report at Codecov.
|
For example:
AttributeTypeAndValues ::= SEQUENCE {
type OBJECT IDENTIFIER,
values SET OF ANY DEFINED BY type
}
This patch adds support of the above ASN.1 syntax to BER/DER/CER
codecs.
It appears that to implement this feature properly, `SetOf`/`SequenceOf`
pyasn1 types need to have `.componentType` wrapped into something
similar to `NamedType` that `Set`/`Sequence` have. That additional
layer would then carry the open type meta information. Without it,
`Sequence`/`Set` codec needs to signal `SetOf`/`SequenceOf` codec
of the open type being processed, which is a slight hack.
A other inconvenience is that when `SetOf`/`SequenceOf` deal with
an open type component, they should not verify types on component
assignment. Without open type property in `SetOf`/`SequenceOf`,
the code checks for `Any` component type which is another hack.
The above shortcomings should be addressed in the follow up patch.
etingof
force-pushed
the
add-set-of-any-support
branch
from
0b01b36 to
d0f4504
Compare
etingof
changed the title
SET OF ANY and SEQUENCE OF ANY constructs supportSET OF ANY and SEQUENCE OF ANY encoding support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
SET|SEQUENCE OF ANYencoding supportFor example:
This patch adds support of the above ASN.1 syntax to BER/DER/CER
codecs.
It appears that to implement this feature properly,
SetOf/SequenceOfpyasn1 types need to have
.componentTypewrapped into somethingsimilar to
NamedTypethatSet/Sequencehave. That additionallayer would then carry the open type meta information. Without it,
Sequence/Setcodec needs to signalSetOf/SequenceOfcodecof the open type being processed, which is a slight hack.
A other inconvenience is that when
SetOf/SequenceOfdeal withan open type component, they should not verify types on component
assignment. Without open type property in
SetOf/SequenceOf,the code checks for
Anycomponent type which is another hack.The above shortcomings should be addressed in the follow up patch.