Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CER/DER encoders to respect open types #167

Merged
merged 2 commits into from
Jul 12, 2019
Merged

Conversation

etingof
Copy link
Owner

@etingof etingof commented Jul 9, 2019

Added a bunch of unit tests to CER/DER codecs covering open types.

@codecov-io
Copy link

codecov-io commented Jul 9, 2019

Codecov Report

Merging #167 into master will increase coverage by 0.66%.
The diff coverage is 90.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   85.61%   86.27%   +0.66%     
==========================================
  Files          29       29              
  Lines        4199     4190       -9     
==========================================
+ Hits         3595     3615      +20     
+ Misses        604      575      -29
Impacted Files Coverage Δ
pyasn1/codec/ber/encoder.py 89.33% <88.88%> (+0.44%) ⬆️
pyasn1/codec/cer/encoder.py 86.02% <93.75%> (+0.51%) ⬆️
pyasn1/codec/ber/decoder.py 89.51% <0%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf9b3f5...63ad106. Read the comment docs.

@etingof etingof force-pushed the fix-cer-der-tagged-any branch from 0934ede to 0be5ec7 Compare July 9, 2019 22:09
etingof added 2 commits July 12, 2019 22:23
Added a bunch of unit tests to CER/DER codecs covering open types.
@etingof etingof force-pushed the fix-cer-der-tagged-any branch from 0be5ec7 to 63ad106 Compare July 12, 2019 20:26
@etingof etingof merged commit 62efcb9 into master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants