Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SET ... WITH COMPONENTS ... ASN.1 construct support #171

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

etingof
Copy link
Owner

@etingof etingof commented Aug 25, 2019

Added WithComponentsConstraint along with related ComponentPresentConstraint
and ComponentAbsentConstraint classes to be used with Sequence/Set types
representing SET ... WITH COMPONENTS ... like ASN.1 constructs.

@codecov-io
Copy link

codecov-io commented Aug 25, 2019

Codecov Report

Merging #171 into master will decrease coverage by 0.02%.
The diff coverage is 71.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   85.99%   85.97%   -0.03%     
==========================================
  Files          29       29              
  Lines        4221     4235      +14     
==========================================
+ Hits         3630     3641      +11     
- Misses        591      594       +3
Impacted Files Coverage Δ
pyasn1/type/char.py 89.31% <ø> (ø) ⬆️
pyasn1/type/univ.py 83.4% <100%> (ø) ⬆️
pyasn1/codec/native/encoder.py 86.31% <50%> (ø) ⬆️
pyasn1/codec/cer/encoder.py 85.5% <66.66%> (ø) ⬆️
pyasn1/codec/ber/encoder.py 88.98% <66.66%> (ø) ⬆️
pyasn1/codec/ber/decoder.py 89.31% <66.66%> (ø) ⬆️
pyasn1/type/base.py 86.34% <68.42%> (ø) ⬆️
pyasn1/type/constraint.py 88.75% <78.57%> (-0.98%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41ce2e5...6cc4b86. Read the comment docs.

@etingof etingof force-pushed the add-with-components-constraint branch from 1eae5ce to 2bc142b Compare August 25, 2019 13:27
Added `WithComponentsConstraint` along with related
`ComponentPresentConstraint` and `ComponentAbsentConstraint` classes
to be used with `Sequence`/`Set` types representing
`SET ... WITH COMPONENTS ...` like ASN.1 constructs.
@etingof etingof force-pushed the add-with-components-constraint branch from 2bc142b to 6cc4b86 Compare August 27, 2019 08:07
@etingof etingof changed the title Add with components constraint Add SET ... WITH COMPONENTS ... ASN.1 construct support Aug 27, 2019
@etingof etingof merged commit d0b7f2e into master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants