Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.8, drop EOL 3.4 #182

Merged
merged 5 commits into from
Nov 16, 2019

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Nov 16, 2019

Follow on from #131.

  • 3.8 was released on 2019-10-14
  • 3.4 was EOL on 2019-03-16

@codecov-io
Copy link

codecov-io commented Nov 16, 2019

Codecov Report

Merging #182 into master will decrease coverage by 0.97%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
- Coverage   86.66%   85.68%   -0.98%     
==========================================
  Files          25       25              
  Lines        4221     4324     +103     
==========================================
+ Hits         3658     3705      +47     
- Misses        563      619      +56
Impacted Files Coverage Δ
pyasn1/compat/integer.py 96.82% <100%> (-0.1%) ⬇️
pyasn1/codec/ber/encoder.py 84.02% <0%> (-4.97%) ⬇️
pyasn1/codec/ber/decoder.py 86.05% <0%> (-2.2%) ⬇️
pyasn1/type/char.py 87.96% <0%> (-1.35%) ⬇️
pyasn1/type/univ.py 84.39% <0%> (-0.19%) ⬇️
pyasn1/codec/cer/encoder.py 85.61% <0%> (+0.1%) ⬆️
pyasn1/type/base.py 86.29% <0%> (+0.33%) ⬆️
pyasn1/type/useful.py 83.5% <0%> (+0.34%) ⬆️
pyasn1/type/tag.py 89.43% <0%> (+0.44%) ⬆️
pyasn1/type/namedtype.py 85.34% <0%> (+0.66%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d2ac0...169ebc1. Read the comment docs.

@etingof
Copy link
Owner

etingof commented Nov 16, 2019

Thank you!

@etingof etingof merged commit fcf7c50 into etingof:master Nov 16, 2019
@hugovk hugovk deleted the update-versions branch November 16, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants