Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise exceptions in consistency check #188

Closed
wants to merge 1 commit into from

Conversation

therve
Copy link

@therve therve commented Dec 18, 2019

isInconsistent can return a boolean, add a new wrapper which checks the
return type and use that instead.

Fixes #178

isInconsistent can return a boolean, add a new wrapper which checks the
return type and use that instead.
@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #188 into master will increase coverage by 0.16%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   85.49%   85.66%   +0.16%     
==========================================
  Files          26       26              
  Lines        4662     4654       -8     
==========================================
+ Hits         3986     3987       +1     
+ Misses        676      667       -9
Impacted Files Coverage Δ
pyasn1/codec/ber/decoder.py 84.31% <100%> (+0.05%) ⬆️
pyasn1/codec/cer/encoder.py 86.52% <100%> (+0.51%) ⬆️
pyasn1/codec/ber/encoder.py 84.91% <100%> (+0.8%) ⬆️
pyasn1/codec/native/encoder.py 86.45% <50%> (+1.45%) ⬆️
pyasn1/type/univ.py 84.41% <75%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de0d16...4a6c641. Read the comment docs.

Lostboi pushed a commit to inexio/pyasn1 that referenced this pull request Dec 21, 2020
@therve therve closed this Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: exceptions must derive from BaseException
2 participants