Fix #224, link to "Layman's Guide" #225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix compatibility with PyPy 3 - move ``setup.py`` infos to ``setup.cfg`` - use ``build`` to build sdist and wheel - simplify ``tox.ini`` - drop Python 3.5 - use ``unittest discover`` to discover tests - https://github.com/etingof -> https://github.com/pyasn1 - drop TravisCI - validate metadata - update maintainer contact
`whitelist_externals` was deprecated as of 3.18 and has been replaced by `allowlist_externals`. Use the new variable name to unbreak CI with py39. Bump the minimum tox version to support the change (3.18 was where `allowlist_externals` was introduced). Signed-off-by: Enji Cooper <[email protected]>
Every other `supportIndefLenMode` are booleans, this seems like a mistake/leftover from python 2
Remove Python 2.7, 3.7, and 3.8 as EOL. Add 3.10 PyPy.
Add missing settings for Python 12 support
RTD now wants an `index.html` file in the root. Otherwise RTD considers the docs broken. Our docs use `contents.html` as entry point. Our RTD configuration has page redirects in place: - `/` -> `/contents.html` - `/index.html` -> `/contents.html` Add a dummy `index.rst` to make RTD happy. The page is hidden in the TOC and just links to start of `contents.html` in the root. The trick ensures that references in 3rd party documentations and search machine indexes are kept happy. Signed-off-by: Christian Heimes <[email protected]>
Partial BER decoding was possible in 0.4.8 and is no longer possible in 0.5.0. It's currently prevented by the strict bytesRead check in state stDecodeValue. We have to relax length check a bit. As a custom substrateFuns can be used for partial decoding, reading less than the definite length is fine and expected. Reading more is fishy. Treat the latter as error. If the length check breaks your existing code, please file a bug for pyasn1 and explain the use case for reading too much.
0.5.0 introduced streaming decoders with new API. decoder.decode() was meant as a compatibility layer, but API broke anyways if users passed a custom substrateFun to decoder.decode(). This happened because substrateFun API and semantics also changed with 0.5.0. To establish full backwards compatibility, we now let decode.decode() accept both v0.4 and v0.5 substrateFuns. v0.4 functions are detected and automatically wrapped to behave streaming-like. Detection of v0.4 style works by checking for TypeError stemming from a call with wrong number of arguments. The try-except approach was chosen over 'import inspect' for performance reasons. We avoid to interfere with user code TypeErrors by checking the traceback depth. Fixes #28.
Use streaming semantics to avoid needless auto-conversion: - don't return value as 1st tuple item, but yield as scalar - don't return next substrate as 2nd tuple item; it's now what's left in the stream
The host ftp.rsasecurity.com does no longer resolve for me. kk:~ kris$ host ftp.rsasecurity.com Host ftp.rsasecurity.com not found: 3(NXDOMAIN) FTP Links are no longer supported directly in many browsers. I replace the link to the text to a PDF version of the document in question, hosted by researchgate.net. This is supposed to be a stable URL, and the formatted document is probably easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #224:
The host ftp.rsasecurity.com does no longer resolve for me.
kk:~ kris$ host ftp.rsasecurity.com
Host ftp.rsasecurity.com not found: 3(NXDOMAIN)
FTP Links are no longer supported directly in many browsers.
I replace the link to the text to a PDF version of the document in question, hosted by researchgate.net. This is supposed to be a stable URL, and the formatted document is probably easier to read.