perf: reduce cookies widget reactivity #2550
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview deployment: https://pr-2550.portal-js.dev.eanadev.org/ |
rwd
changed the title
|
After further testing, improvement to event time is not evident for others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vue data and computed properties are reactive, whereas those set on the vm in
created(without being declared indata) are static.Utilise this to reduce the reactivity of the properties in cookies/service management components and the klaro mixin where they don't need to be reactive, reducing main thread work and event duration e.g. when opening the cookies widget modal.
Measurable using dev tools, performance tab, start a recording, open the cookies widget modal, stop the recording, observe the click event duration. Compare to duration without the reactivity reduction. Reduction from ~ 42 ms to ~ 26 ms observed.