refactor: multilingual advanced search #2702
Conversation
…ed for multilingual search
|
JIRA ticket: EC-7150 |
| // concatenate any advanced search rules with added entity value | ||
| if (this.qaes.length) { | ||
| params.query = params.query | ||
| .concat(' OR ').concat(this.qaes.join(' OR ')); |
There was a problem hiding this comment.
Shouldn't the first OR here be an AND? i.e.
params.query = params.query
.concat(' AND ').concat(this.qaes.join(' OR '));There was a problem hiding this comment.
No, what this does is add the entity URI value queries for which we have custom entity look up (e.g. 'creator', 'subject', defined in advancedSearch mixin). The same fields with the keyword value are added before. If we AND that first OR it will AND only the first entity value query and returns only results filtered to the advanced search field value that contain both the keyword and entity value, which in many cases seem to be much less.
Looking at this again though and trying multiple advanced search queries, I think the keyword and entity values should be added to just one field instead with an OR (for example proxy_dc_subject:(Agricultura+OR+"http://data.europeana.eu/concept/134"), but we'll have to see what effect that has on multilingual search.
No description provided.