feat: create @europeana/map component package#335
Merged
Conversation
Contributor
|
JIRA ticket: EC-7808 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
lbiedinger
reviewed
Jun 26, 2026
| if (props.json) { | ||
| data.value = JSON.parse(props.json); | ||
| } else if (props.url) { | ||
| useFetch(props.url) |
Member
There was a problem hiding this comment.
Consider validating URL to limit this to only fetching the url if it matches whitelisted endpoints.
Contributor
Author
There was a problem hiding this comment.
That would severely limit its reusability.
lbiedinger
requested changes
Jun 29, 2026
|
|
||
| ## Usage | ||
|
|
||
| TODO |
Member
There was a problem hiding this comment.
let's document the available scripts here already. dev/build/preview
Maybe also a note about versioning?
| @@ -0,0 +1,10 @@ | |||
| <svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
Member
There was a problem hiding this comment.
I wonder if we could add this to the iconmoo font like we manage the other icons.
Contributor
Author
There was a problem hiding this comment.
I doubt that given that OpenLayers expects an image src.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@europeana/mapfor a component to render a map using OpenLayers & OpenStreetMap, displaying clustered points for GeoJSON data supplied either directly in the json prop/attribute or accessible via the URL inthe url prop/attribute
pnpm --filter @europeana/map devpnpm --filter @europeana/map buildpnpm --filter @europeana/map previewpnpm --filter @europeana/map publish --access publicpnpm dlx lerna version)