Fix - Issue #171 #235
Draft
Fix - Issue #171 #235
+134
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-server-mode Fix SSE timeout when chaining agents
|
@evalstate I will test this PR tomorrow and I will update you the status ;) |
…or-in-mcp-server-mode Revert "Fix SSE timeout when chaining agents"
…sponse-aggregation Implement chain response aggregator for server mode
…hain-response-aggregation Implement chain response aggregator for server mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the
AgentMCPServerby addressing issues with SSE (Server-Sent Events) transport and improving authentication handling. The most significant changes include patching theFastMCP.sse_appmethod to resolve ASGI errors, introducing middleware for authentication, and updating the routing logic for SSE and messaging endpoints.Improvements to SSE Handling:
FastMCP.sse_appmethod to prevent returning a secondResponseafter the SSE connection completes. This resolves the"Unexpected ASGI message 'http.response.start'"errors and prevents timeouts when chaining agents in server mode. (src/mcp_agent/mcp_server/agent_server.py, src/mcp_agent/mcp_server/agent_server.pyR55-R147)Authentication Enhancements:
AuthenticationMiddleware,AuthContextMiddleware, andRequireAuthMiddlewarewithBearerAuthBackend. This ensures secure handling of SSE and messaging endpoints. (src/mcp_agent/mcp_server/agent_server.py, src/mcp_agent/mcp_server/agent_server.pyR15-R28)src/mcp_agent/mcp_server/agent_server.py, src/mcp_agent/mcp_server/agent_server.pyR55-R147)Documentation Update:
FastMCP.sse_appmethod. (src/mcp_agent/mcp_server/agent_server.py, src/mcp_agent/mcp_server/agent_server.pyL1-R6)