Balance Checks #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| '''Get conditional mean for covariate of interested with respect to | ||
| value of running variable and treatment condition. | ||
| ''' | ||
| trt_conditional_mean = trt.groupby('X').mean() |
There was a problem hiding this comment.
@divyansha I'm worried how this will play out when X is continuous -- it could be very noisy, and in many cases it would simply be the mean of 1 observation. Could we instead cut the data into 100/500/etc bins?
There was a problem hiding this comment.
Good point, thanks for the insight. How about creating a default bin width of 100 (just picking a number, no good logic behind picking 100), and letting the user specify their desired bin width?
There was a problem hiding this comment.
That sounds good to me - maybe we could do a default of 30-50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote functions for visual balance checks and balance checks using placebo outcomes