Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firewall hint to ConnectingSplash #278

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FunctionDJ
Copy link

No description provided.

@vercel
Copy link

vercel bot commented Oct 18, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @evanpurkhiser on Vercel.

@evanpurkhiser first needs to authorize it.

@FunctionDJ
Copy link
Author

@evanpurkhiser Can you comment on why you've closed this PR?

@evanpurkhiser
Copy link
Owner

oops, this looks like an accident

@evanpurkhiser evanpurkhiser reopened this Feb 27, 2023
@vercel
Copy link

vercel bot commented Feb 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
prolink-tools ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 27, 2023 at 10:41PM (UTC)

@evanpurkhiser
Copy link
Owner

The reason I generally haven't merged this yet is

  1. This is already docuemnted in the manuals troubleshooting section, which the current message links too.
  2. I haven't had a chance to look at how the text looks with this in it. If you could attach a screenshot that would be helpful!

@FunctionDJ
Copy link
Author

I'll see if i can provide a screenshot soon. I noticed that the troubleshooting section recommends to disable the firewall instead of allowing the app through it. I don't think it's a good idea to recommend this to users without further context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants