Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Vertical alignment of titles with their corresponding card content -issue(#3462) #3730

Merged
merged 1 commit into from
Apr 5, 2025

Conversation

AnicetFantomas
Copy link
Contributor

@AnicetFantomas AnicetFantomas commented Apr 4, 2025

Description

  • align the titles vertically to their repective related content in the card on all the screen sizes

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Previous screenshots

image

Current screenshots

Please add here videos or images of the current (new) status

Summary by CodeRabbit

  • Style
    • Refined the team card interface with improved spacing, alignment, and responsiveness.
    • Streamlined the layout for cleaner, more consistent visual presentation.

…nding to their repective related content in the card on all the screen sizes
@CLAassistant
Copy link

CLAassistant commented Apr 4, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here: https://app.greptile.com/review/github.

💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

coderabbitai bot commented Apr 4, 2025

Walkthrough

The changes update the layout and styling within the UserTeamCardHeader function in the task skeleton. Adjustments include removing extra spacing, simplifying nested <div> structures, and modifying class names to improve alignment and responsiveness. No functional aspects of the component have been altered.

Changes

File Change Summary
apps/web/.../user-team-card/task-skeleton.tsx Revised JSX structure in UserTeamCardHeader: removed redundant spacing and the justify-around class; added ml-6 with a fixed width (w-72); simplified nested divs and updated layout classes.

Possibly related PRs

Suggested labels

UI/UX, Improvement, Bug fix, Ever Teams

Suggested reviewers

  • evereq
  • NdekoCode
  • Cedric921

Poem

I hopped through lines of code today,
Tweaking layouts in a playful way.
No bug or error in sight, just style so clear,
With fixed widths and spacing, everything’s dear.
A rabbit’s dance in the developer's glen,
Celebrating changes again and again!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/lib/features/team/user-team-card/task-skeleton.tsx

Oops! Something went wrong! :(

ESLint: 8.46.0

ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct.

The config "next/core-web-vitals" was referenced from the config file in "/apps/web/.eslintrc.json".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eca08c2 and 5c17d73.

📒 Files selected for processing (1)
  • apps/web/lib/features/team/user-team-card/task-skeleton.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: deploy
🔇 Additional comments (8)
apps/web/lib/features/team/user-team-card/task-skeleton.tsx (8)

46-46: Clean container styling improves base layout.

The modification to add m-0 and adjust padding improves the overall container layout, which will help with child element alignment.


48-49: Better horizontal spacing in the flex container.

Removing justify-around and adding the fixed width (w-72) with ml-6 creates more consistent spacing, which directly addresses the alignment issue mentioned in the PR.


50-50: Simplified div structure maintains text integrity.

The simplified structure with text-nowrap ensures the team member label stays intact while maintaining proper alignment.


57-59: Improved responsive sizing for task column.

The use of flexible width with minimum constraints (md:min-w-[25%], xl:min-w-[30%]) and maximum constraint (!max-w-[250px]) ensures consistent alignment across different viewport sizes.


63-63: Enhanced alignment for task time section.

Adding flex justify-start items-center pl-6 properly aligns the tooltip content with other headers, while responsive widths ensure consistency across screen sizes.


71-73: Consistent heading alignment for the estimate section.

The alignment properties (flex items-center justify-start pl-6) and responsive widths match the pattern established in other sections, creating visual consistency.


77-77: Balanced width constraints for the total today section.

The responsive width approach (w-1/5 2xl:w-52 max-w-[13rem]) with centered content ensures proper alignment with the content below at various screen sizes.


86-86: Added trailing spacer ensures consistent right margin.

The addition of this spacer div (w-10) provides balanced spacing on the right side of the header row, preventing content from appearing too close to the edge.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@AnicetFantomas AnicetFantomas requested a review from NdekoCode April 4, 2025 10:17
@AnicetFantomas AnicetFantomas changed the title [Fix]: Vertical alignment of titles with their corresponding card content on Team page (Issue #3462) [Fix]: Vertical alignment of titles with their corresponding card content Apr 4, 2025
@AnicetFantomas AnicetFantomas changed the title [Fix]: Vertical alignment of titles with their corresponding card content [Fix]: Vertical alignment of titles with their corresponding card content -issue(#3462) Apr 4, 2025
Copy link
Contributor

@Innocent-Akim Innocent-Akim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean code, all good ✅

@Innocent-Akim
Copy link
Contributor

Otherwise, start by adding two screenshots: one showing the problem and another showing the solution. @AnicetFantomas

@AnicetFantomas
Copy link
Contributor Author

Otherwise, start by adding two screenshots: one showing the problem and another showing the solution. @AnicetFantomas
Sure, @Innocent-Akim 😄

Here is the issue we had
image

Here is the update
image

@NdekoCode NdekoCode linked an issue Apr 5, 2025 that may be closed by this pull request
@NdekoCode NdekoCode requested a review from evereq April 5, 2025 16:35
@evereq evereq merged commit 94e342a into develop Apr 5, 2025
14 of 16 checks passed
@evereq evereq deleted the Fx/Alignment-titles-team-page branch April 5, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Fixes - Alignment of titles on Team page
5 participants