Draft
Conversation
Contributor
kindermax
commented
Dec 23, 2025
kindermax
commented
- Add conditions support
- refactor tests to use WithContext API and update README
added 2 commits
December 23, 2025 15:34
- Refactor all test files to use featureflags.WithContext(ctx) instead of passing context map directly - Update flags_test.go: replace context map parameters with WithContext() - Update values_test.go: refactor GetValue*, GetValueInt, GetValueString, MustGetValue* tests - Update client_test.go: update Get() calls to use new API - Add comprehensive README section explaining context and conditions - Document difference between simple mode (no context) and conditional mode (with context) - Add example code showing both usage patterns - Clarify when server conditions are evaluated vs ignored All tests passing after refactoring.
kindermax
force-pushed
the
conditions-support
branch
from
1430a28 to
2255f1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.