Skip to content

Allow to run HTTP API server without GRPC server #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hyzyla wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow to run HTTP API server without GRPC server #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion featureflags/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class Config(BaseSettings):
sentry: SentrySettings

app: AppSettings
rpc: RpcSettings
rpc: RpcSettings | None = None
http: HttpSettings


Expand Down
4 changes: 4 additions & 0 deletions featureflags/rpc/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ async def create_server(


async def main() -> None:

if config.rpc is None:
raise ValueError("GRPC configuration is not set, check your config")

async with contextlib.AsyncExitStack() as stack:
container = Container()
await container.init_resources()
Expand Down