Skip to content

fix(frontend): show password complexity errors and inline checklist (EVO-992) #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpaes merged 1 commit into from
May 11, 2026
Merged

fix(frontend): show password complexity errors and inline checklist (EVO-992) #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/i18n/locales/en/profile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,21 @@
"validation": {
"allFields": "All fields are required",
"mismatch": "Passwords do not match",
"minLength": "Password must be at least 6 characters"
"minLength": "Password must be at least 8 characters"
},
"errors": {
"too_short": "Password must be at least 8 characters",
"missing_uppercase": "Must include at least one uppercase letter (A-Z)",
"missing_lowercase": "Must include at least one lowercase letter (a-z)",
"missing_number": "Must include at least one number (0-9)",
"missing_special_char": "Must include at least one special character (!@#$...)"
},
"rules": {
"minLength": "At least 8 characters",
"uppercase": "At least one uppercase letter (A-Z)",
"lowercase": "At least one lowercase letter (a-z)",
"number": "At least one number (0-9)",
"specialChar": "At least one special character (!@#$...)"
}
},
"accessToken": {
Expand Down
16 changes: 15 additions & 1 deletion src/i18n/locales/pt-BR/profile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,21 @@
"validation": {
"allFields": "Todos os campos são obrigatórios",
"mismatch": "As senhas não coincidem",
"minLength": "A senha deve ter no mínimo 6 caracteres"
"minLength": "A senha deve ter no mínimo 8 caracteres"
},
"errors": {
"too_short": "A senha deve ter no mínimo 8 caracteres",
"missing_uppercase": "Deve incluir pelo menos uma letra maiúscula (A-Z)",
"missing_lowercase": "Deve incluir pelo menos uma letra minúscula (a-z)",
"missing_number": "Deve incluir pelo menos um número (0-9)",
"missing_special_char": "Deve incluir pelo menos um caractere especial (!@#$...)"
},
"rules": {
"minLength": "Mínimo 8 caracteres",
"uppercase": "Pelo menos uma letra maiúscula (A-Z)",
"lowercase": "Pelo menos uma letra minúscula (a-z)",
"number": "Pelo menos um número (0-9)",
"specialChar": "Pelo menos um caractere especial (!@#$...)"
}
},
"accessToken": {
Expand Down
134 changes: 84 additions & 50 deletions src/pages/Shared/Profile/Profile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import {
Switch,
Checkbox,
} from '@evoapi/design-system';
import { AlertTriangle, Mail, Volume2, Bell, Keyboard, Play } from 'lucide-react';
import { AlertTriangle, Mail, Volume2, Bell, Keyboard, Play, Check, X } from 'lucide-react';
import { toast } from 'sonner';
import { useAuth } from '@/contexts/AuthContext';
import { useAuthStore } from '@/store/authStore';
Expand All @@ -38,6 +38,7 @@ import {
type ProfileUpdateData,
type PasswordChangeData,
} from '@/services/profile/profileService';
import { extractError } from '@/utils/apiHelpers';
import notificationSettingsService from '@/services/notifications/NotificationSettingsService';
import { getAudioSettings, playNotificationSoundPreview } from '@/utils/audioNotificationUtils';
import { getModifierKey } from '@/utils/platform';
Expand Down Expand Up @@ -396,7 +397,6 @@ const Profile = () => {
};

const handleChangePassword = async () => {
// Validação básica
if (!passwords.current_password || !passwords.password || !passwords.password_confirmation) {
toast.error(t('password.validation.allFields'));
return;
Expand All @@ -407,7 +407,7 @@ const Profile = () => {
return;
}

if (passwords.password.length < 6) {
if (passwords.password.length < 8) {
toast.error(t('password.validation.minLength'));
return;
}
Expand All @@ -430,7 +430,20 @@ const Profile = () => {
});
} catch (error) {
console.error('Password change error:', error);
toast.error(t('notifications.passwordChangeError'));
const errorInfo = extractError(error);
if (errorInfo.code === 'VALIDATION_ERROR' && Array.isArray(errorInfo.details)) {
const passwordDetail = errorInfo.details.find((d: { field: string; codes?: string[] }) => d.field === 'password');
if (passwordDetail?.codes?.length) {
passwordDetail.codes.forEach((code: string) => {
const key = `password.errors.${code.replace('password.', '')}`;
toast.error(t(key));
});
} else {
toast.error(t('notifications.passwordChangeError'));
}
} else {
toast.error(t('notifications.passwordChangeError'));
}
} finally {
setIsLoading(false);
}
Expand Down Expand Up @@ -516,56 +529,77 @@ const Profile = () => {
</Card>
);

const renderSenha = () => (
<Card>
<CardHeader>
<CardTitle>{t('password.title')}</CardTitle>
<CardDescription>{t('password.description')}</CardDescription>
</CardHeader>
<CardContent>
<div className="max-w-md space-y-6">
<div className="space-y-2">
<Label htmlFor="senha-atual">{t('password.fields.currentPassword')} *</Label>
<Input
id="senha-atual"
type="password"
value={passwords.current_password}
onChange={handlePasswordInputChange('current_password')}
placeholder={t('password.fields.currentPlaceholder')}
/>
</div>
const renderSenha = () => {
const newPassword = passwords.password;
const complexityRules = [
{ key: 'minLength', met: newPassword.length >= 8 },
{ key: 'uppercase', met: /[A-Z]/.test(newPassword) },
{ key: 'lowercase', met: /[a-z]/.test(newPassword) },
{ key: 'number', met: /\d/.test(newPassword) },
{ key: 'specialChar', met: /[^A-Za-z0-9]/.test(newPassword) },
];

<div className="space-y-2">
<Label htmlFor="nova-senha">{t('password.fields.newPassword')} *</Label>
<Input
id="nova-senha"
type="password"
value={passwords.password}
onChange={handlePasswordInputChange('password')}
placeholder={t('password.fields.newPlaceholder')}
/>
</div>
return (
<Card>
<CardHeader>
<CardTitle>{t('password.title')}</CardTitle>
<CardDescription>{t('password.description')}</CardDescription>
</CardHeader>
<CardContent>
<div className="max-w-md space-y-6">
<div className="space-y-2">
<Label htmlFor="senha-atual">{t('password.fields.currentPassword')} *</Label>
<Input
id="senha-atual"
type="password"
value={passwords.current_password}
onChange={handlePasswordInputChange('current_password')}
placeholder={t('password.fields.currentPlaceholder')}
/>
</div>

<div className="space-y-2">
<Label htmlFor="confirmar-senha">{t('password.fields.confirmPassword')} *</Label>
<Input
id="confirmar-senha"
type="password"
value={passwords.password_confirmation}
onChange={handlePasswordInputChange('password_confirmation')}
placeholder={t('password.fields.confirmPlaceholder')}
/>
</div>
<div className="space-y-2">
<Label htmlFor="nova-senha">{t('password.fields.newPassword')} *</Label>
<Input
id="nova-senha"
type="password"
value={passwords.password}
onChange={handlePasswordInputChange('password')}
placeholder={t('password.fields.newPlaceholder')}
/>
{newPassword.length > 0 && (
<ul className="mt-2 space-y-1">
{complexityRules.map(({ key, met }) => (
<li key={key} className={`flex items-center gap-1.5 text-xs ${met ? 'text-green-600 dark:text-green-400' : 'text-muted-foreground'}`}>
{met ? <Check className="h-3 w-3" /> : <X className="h-3 w-3" />}
{t(`password.rules.${key}`)}
</li>
))}
</ul>
)}
</div>

<div className="flex justify-end">
<Button onClick={handleChangePassword} disabled={isLoading} className="min-w-[120px]">
{isLoading ? t('password.actions.changing') : t('password.actions.changePassword')}
</Button>
<div className="space-y-2">
<Label htmlFor="confirmar-senha">{t('password.fields.confirmPassword')} *</Label>
<Input
id="confirmar-senha"
type="password"
value={passwords.password_confirmation}
onChange={handlePasswordInputChange('password_confirmation')}
placeholder={t('password.fields.confirmPlaceholder')}
/>
</div>

<div className="flex justify-end">
<Button onClick={handleChangePassword} disabled={isLoading} className="min-w-[120px]">
{isLoading ? t('password.actions.changing') : t('password.actions.changePassword')}
</Button>
</div>
</div>
</div>
</CardContent>
</Card>
);
</CardContent>
</Card>
);
};

// const handleCopyToken = async () => {
// // Primeiro tenta buscar do perfil carregado, depois do contexto
Expand Down