ci: run validate-compose and lint-dockerfiles on PRs to develop#59
Merged
Conversation
Extend the CI trigger so PRs targeting `develop` are checked the same way as PRs to `main`. Without this, any PR merged to develop (including staging-bound fixes and refactors) entered without docker-compose validation or Dockerfile linting. No change to the jobs themselves — only the trigger list. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate CI workflow so that pull_request-triggered jobs run for both main and develop branches, ensuring validate-compose and lint-dockerfiles execute on PRs targeting develop as well as main. Flow diagram for pull_request branch filter in CI workflowflowchart TD
A["Open pull request"] --> B["Evaluate target branch"]
B -->|main| C["Trigger CI workflow"]
B -->|develop| C
B -->|other branch| D["Do not trigger this workflow"]
C --> E["Run validate-compose job"]
C --> F["Run lint-dockerfiles job"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
developto thepull_request.branchesfilter in.github/workflows/ci.yml.docker-compose.ymland lint all 5 Dockerfiles on every PR targetingdevelop, not onlymain.Motivation
Today, PRs to
developbypass CI entirely. This let the last few PRs merge into develop without any compose validation or hadolint checks. Since develop is the staging integration branch, broken compose or Dockerfiles compound and only surface at thedevelop → mainmerge — exactly when they are most expensive to fix.Test plan
validate-composeandlint-dockerfilesjobs run.🤖 Generated with Claude Code
Summary by Sourcery
CI: