Skip to content

ci: run validate-compose and lint-dockerfiles on PRs to develop#59

Merged
DavidsonGomes merged 1 commit into
developfrom
chore/ci-run-on-develop-prs
Apr 23, 2026
Merged

ci: run validate-compose and lint-dockerfiles on PRs to develop#59
DavidsonGomes merged 1 commit into
developfrom
chore/ci-run-on-develop-prs

Conversation

@DavidsonGomes
Copy link
Copy Markdown
Member

@DavidsonGomes DavidsonGomes commented Apr 23, 2026

Summary

  • Add develop to the pull_request.branches filter in .github/workflows/ci.yml.
  • Validate docker-compose.yml and lint all 5 Dockerfiles on every PR targeting develop, not only main.

Motivation

Today, PRs to develop bypass CI entirely. This let the last few PRs merge into develop without any compose validation or hadolint checks. Since develop is the staging integration branch, broken compose or Dockerfiles compound and only surface at the develop → main merge — exactly when they are most expensive to fix.

Test plan

  • Merge this PR → open a new PR against develop → confirm validate-compose and lint-dockerfiles jobs run.
  • Open a PR against main → jobs still run (unchanged).

🤖 Generated with Claude Code

Summary by Sourcery

CI:

  • Extend the GitHub Actions pull_request trigger to include the develop branch in addition to main so CI runs on both.

Extend the CI trigger so PRs targeting `develop` are checked the same
way as PRs to `main`. Without this, any PR merged to develop (including
staging-bound fixes and refactors) entered without docker-compose
validation or Dockerfile linting.

No change to the jobs themselves — only the trigger list.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 23, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update CI workflow so that pull_request-triggered jobs run for both main and develop branches, ensuring validate-compose and lint-dockerfiles execute on PRs targeting develop as well as main.

Flow diagram for pull_request branch filter in CI workflow

flowchart TD
  A["Open pull request"] --> B["Evaluate target branch"]
  B -->|main| C["Trigger CI workflow"]
  B -->|develop| C
  B -->|other branch| D["Do not trigger this workflow"]

  C --> E["Run validate-compose job"]
  C --> F["Run lint-dockerfiles job"]
Loading

File-Level Changes

Change Details Files
Broaden CI pull_request branch filter to include the develop branch so validation and linting jobs run on PRs to develop.
  • Extend the GitHub Actions pull_request.branches filter from only main to both main and develop
  • Leave existing validate-compose and lint-dockerfiles jobs intact so their behavior is unchanged aside from running on more PRs
.github/workflows/ci.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@DavidsonGomes DavidsonGomes merged commit d8bc789 into develop Apr 23, 2026
3 checks passed
@DavidsonGomes DavidsonGomes deleted the chore/ci-run-on-develop-prs branch April 23, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant