chore: reduce log noise #2864
chore: reduce log noise #2864
Conversation
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
Summary of ChangesHello @tac0turtle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to significantly reduce log noise, particularly in scenarios where a node is syncing from the Data Availability layer and might be far ahead of the DA sync height. By consolidating block processing logs and lowering the verbosity of header and data decoding messages, the changes provide a cleaner and more focused logging output, enhancing the clarity of operational logs without sacrificing essential information for debugging. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Claude finished @tac0turtle's task —— View job Code Review Complete ✅I've reviewed the logging changes in this PR. Here's my comprehensive feedback: Summary of ChangesThis PR makes three targeted changes to reduce log noise in
Review Feedback✅ Strengths
🔍 Observations & Suggestions1. Log Consistency Pattern ( if len(events) > 0 {
r.logger.Info().Int("count", len(events)).Uint64("da_height", daHeight).Msg("processed blocks from DA")
}✅ Good: Conditional logging prevents "processed 0 blocks" noise
2. Debug-level Messages Still Valuable (
3. Semantic Improvement in Message 4. No Breaking Changes Code Quality Assessment
Verification QuestionsTo ensure completeness, consider these scenarios:
Final RecommendationApprove ✅ - This PR accomplishes its goal cleanly and correctly. The changes are:
The log noise reduction will improve operational clarity, especially in the described scenario where p2p sync is ahead of DA sync. Todo List
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively reduces log noise during DA sync. The changes involve lowering the severity of frequent log messages from Info to Debug and consolidating individual block processing logs into a single summary message per DA height. These modifications are well-aligned with the goal of reducing log pollution and have been implemented correctly. The overall code quality is improved by making the logs less verbose during normal operation while retaining details at the debug level.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2864 +/- ##
==========================================
- Coverage 64.89% 64.80% -0.10%
==========================================
Files 81 81
Lines 7242 7243 +1
==========================================
- Hits 4700 4694 -6
- Misses 1998 2005 +7
Partials 544 544
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Overview
this pr proposes reducing log noise when syncing from da. In our case we recommend p2p is set so now the node can be far ahead of da sync height and this causes log pollution
here are the logs today