Skip to content

add websets beta client #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 21, 2025
Merged

add websets beta client #70

merged 11 commits into from
Mar 21, 2025

Conversation

gabrielcammany
Copy link
Contributor

No description provided.

Copy link
Contributor

@jeffzwang jeffzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks mainly good, maybe let o1 pro take a pass

one high level thing, are there any ergonomic helper fns that don't just wrap an endpoint, that we are missing here?

Copy link
Contributor

@jeffzwang jeffzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have any auto handle pagination calls logic built in?

Copy link
Contributor

@jeffzwang jeffzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possible to make most of the class methods flat, so that class instantiation is less necessary? maybe not given the complexity but it would be very n ice if things were flatter

@jeffzwang jeffzwang merged commit 030adf7 into master Mar 21, 2025
1 check passed
@jeffzwang jeffzwang deleted the feat/add-websets-beta-client branch March 21, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants