Single logout with oauth #1562
Open
Single logout with oauth #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oreno4649
reviewed
Jan 28, 2025
src/Controllers/AuthTrait.php
Outdated
| switch ($login_user->login_type) { | ||
| case LoginType::SAML: | ||
| return $this->logoutSaml($request, $login_user->login_provider, $options); | ||
| break; |
There was a problem hiding this comment.
CIでエラーがでていますがこちらのbreak;は到達不能のため削除していただければと思います
There was a problem hiding this comment.
@oreno4649
アドバイスありがとうございました。
無事にphpstanのチェックをパスできました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
実施タスク
なし
実施内容
レビューして欲しいこと