Replace SwashBuckle with Scalar, Replace JSON.NET from API Surface with STJ #2041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niemyjski
force-pushed
the
feature/scalar-system-text-json
branch
from
612abcd to
f6a5805
Compare
niemyjski
force-pushed
the
feature/scalar-system-text-json
branch
from
f6a5805 to
24bd01b
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+113
to
+122
| foreach (var propertyName in value.GetChangedPropertyNames()) | ||
| { | ||
| if (value.TryGetPropertyValue(propertyName, out var propertyValue)) | ||
| { | ||
| // Convert property name to snake_case if needed | ||
| var jsonPropertyName = options.PropertyNamingPolicy?.ConvertName(propertyName) ?? propertyName; | ||
| writer.WritePropertyName(jsonPropertyName); | ||
| JsonSerializer.Serialize(writer, propertyValue, _options); | ||
| } | ||
| } |
| return cachedDoc; | ||
| } | ||
|
|
||
| var xmlPath = Path.Combine(AppContext.BaseDirectory, $"{assemblyName}.xml"); |
| { | ||
| // Arrange | ||
| string baselinePath = Path.Combine("..", "..", "..", "Controllers", "Data", "swagger.json"); | ||
| string baselinePath = Path.Combine("..", "..", "..", "Controllers", "Data", "openapi.json"); |
Comment on lines
+36
to
+43
| if (schema.Properties.TryGetValue(schemaPropertyName, out var propertySchema)) | ||
| { | ||
| // Cast to OpenApiSchema to access mutable properties | ||
| if (propertySchema is OpenApiSchema mutableSchema) | ||
| { | ||
| mutableSchema.ReadOnly = true; | ||
| } | ||
| } |
Comment on lines
+21
to
+28
| if (methodInfo is null) | ||
| { | ||
| // For controller actions, try to get from ControllerActionDescriptor | ||
| if (context.Description.ActionDescriptor is Microsoft.AspNetCore.Mvc.Controllers.ControllerActionDescriptor controllerDescriptor) | ||
| { | ||
| methodInfo = controllerDescriptor.MethodInfo; | ||
| } | ||
| } |
Comment on lines
+23
to
+30
| if (methodInfo is null) | ||
| { | ||
| // For controller actions, try to get from ControllerActionDescriptor | ||
| if (context.Description.ActionDescriptor is Microsoft.AspNetCore.Mvc.Controllers.ControllerActionDescriptor controllerDescriptor) | ||
| { | ||
| methodInfo = controllerDescriptor.MethodInfo; | ||
| } | ||
| } |
Comment on lines
+111
to
+114
| catch | ||
| { | ||
| return null; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP, it's really close but some serialization stuff needs to be refactored and cleaned up, mainly the websocket manager.