-
Notifications
You must be signed in to change notification settings - Fork 85
ECE/CSC 517 Spring 2025 Group E2534 Final Project: UI for Assign Reviewers #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
delaneydow
wants to merge
48
commits into
expertiza:main
Choose a base branch
from
delaneydow:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI Scaffolding & Interfaces
This was scaffolding and ends up violating DRY since AssignReviewer.tsx already exists and this is what we are adding functionality to
Getting latest updates so that I can modularize & add test cases
Assign reviewer buttons, 3 column layout is partly done
Moving table UI into DMD-dev
Key changes include: 1. Updated App.tsx to have appropriate wrappings & routes 2. Added a context folder that shares the logic of updating reviewers between AssignReviewers and AddReviewers, but can be adapted for use by any other pages in the future. This includes a ReviewerContext file and a ReviewerContextWrapper file. 3. Added AddReviewers page which handles adding of reviewers after the "Add Reviewers" button is clicked on the Assign Reviewers page 4. Updated logic in Assign Reviewers to redirect appropriately to Add Reviewers page
Modifying Context path in add reviewer to satisfy compilation errors
…iewer mappings Detailed changes: 1. Fixed all compilation errors 2. Adjusted topic selection. Now ReviewerContext takes the DummyTopics.JSON file and maps it to the appropriate fields defined in the TopicWithReviews interface 3. Topic Identifier logic adjusted in AddReviewer.tsx and AssignReviewer.tsx 4. Comments added to key elements of the code
1. Updated context logic and local memory saving to ensure changes made persist across refresh 2. Updated AddReviewer UI to fit project description 3. Additional cleaning, commenting, error handling, etc.
Add reviewer page logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.