Skip to content

Conversation

delaneydow
Copy link

No description provided.

Delaney Dow and others added 30 commits April 14, 2025 14:12
UI Scaffolding & Interfaces
This was scaffolding and ends up violating DRY since AssignReviewer.tsx already exists and this is what we are adding functionality to
Getting latest updates so that I can modularize & add test cases
Assign reviewer buttons, 3 column layout is partly done
Moving table UI into DMD-dev
Key changes include:
1. Updated App.tsx to have appropriate wrappings & routes
2. Added a context folder that shares the logic of updating reviewers between AssignReviewers and AddReviewers, but can be adapted for use by any other pages in the future. This includes a ReviewerContext file and a ReviewerContextWrapper file.
3. Added AddReviewers page which handles adding of reviewers after the "Add Reviewers" button is clicked on the Assign Reviewers page
4. Updated logic in Assign Reviewers to redirect appropriately to Add Reviewers page
elnaz-72 and others added 16 commits April 20, 2025 17:21
Modifying Context path in add reviewer to satisfy compilation errors
…iewer mappings

Detailed changes:

1. Fixed all compilation errors
2. Adjusted topic selection. Now ReviewerContext takes the DummyTopics.JSON file and maps it to the appropriate fields defined in the TopicWithReviews interface
3. Topic Identifier logic adjusted in AddReviewer.tsx and AssignReviewer.tsx
4. Comments added to key elements of the code
1. Updated context logic and local memory saving to ensure changes made persist across refresh
2. Updated AddReviewer UI to fit project description
3. Additional cleaning, commenting, error handling, etc.
@delaneydow delaneydow marked this pull request as ready for review April 23, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants