Skip to content

fix: non default temperature check #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: non default temperature check #2134

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17bdc33
non default temperature check
Jul 23, 2025
43be929
branch if no model_name attr
Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions ragas/src/ragas/llms/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
VertexAI,
]

MODELS_NOT_SUPPORT_TEMP = ['o3-mini', 'o4-mini', 'o3']


def is_multiple_completion_supported(llm: BaseLanguageModel) -> bool:
"""Return whether the given LLM supports n-completion."""
Expand Down Expand Up @@ -205,8 +207,13 @@ def generate_text(
if temperature is None:
temperature = self.get_temperature(n=n)
if hasattr(self.langchain_llm, "temperature"):
self.langchain_llm.temperature = temperature # type: ignore
old_temperature = temperature
if hasattr(self.langchain_llm, "model_name"):
if self.langchain_llm.model_name not in MODELS_NOT_SUPPORT_TEMP:
self.langchain_llm.temperature = temperature # type: ignore
old_temperature = temperature
else:
self.langchain_llm.temperature = temperature
old_temperature = temperature

if is_multiple_completion_supported(self.langchain_llm):
result = self.langchain_llm.generate_prompt(
Expand Down Expand Up @@ -245,8 +252,13 @@ async def agenerate_text(
if temperature is None:
temperature = self.get_temperature(n=n)
if hasattr(self.langchain_llm, "temperature"):
self.langchain_llm.temperature = temperature # type: ignore
old_temperature = temperature
if hasattr(self.langchain_llm, "model_name"):
if self.langchain_llm.model_name not in MODELS_NOT_SUPPORT_TEMP:
self.langchain_llm.temperature = temperature # type: ignore
old_temperature = temperature
else:
self.langchain_llm.temperature = temperature
old_temperature = temperature

# handle n
if hasattr(self.langchain_llm, "n"):
Expand Down