redundant init and consistency of loop exit #2135
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
in
ragas/src/ragas/testset/synthesizers/multi_hop/specific.py
exit condition was like
if len(scenarios) < n:
,but in other files
(
ragas/src/ragas/testset/synthesizers/single_hop/specific.py
m line 103) and (ragas/src/ragas/testset/synthesizers/multi_hop/abstract.py
, line 85)it was
if len(scenarios) >= n: break