[core][jsi] Zero-copy NativeArrayBuffer for native-backed data#46448
Merged
Conversation
850a7df to
00681f5
Compare
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: 4d40f2d Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/@expo/log-box",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "96eb947558c668452910b38e19e8acd4e20e45f2"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/@expo/log-box",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "d6e686eaa34955d1afa8fe5da9c2b07516bcd39a"
}
},
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoConfigPlugins",
"expoConfigPlugins",
"rncoreAutolinkingAndroid",
"rncoreAutolinkingIos"
],
"hash": "5064c0fd09c047836a6169b03f0b80db9db7e3b2"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoConfigPlugins",
"expoConfigPlugins",
"rncoreAutolinkingAndroid",
"rncoreAutolinkingIos"
],
"hash": "2b6bb3ebf5b4cdccd9c36d1f03696a1756ca44fb"
}
},
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-dev-launcher",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "c82b5613bfcbfc95144780b10454785b810331c3"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-dev-launcher",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "81ca1f6ab42ee720cf236ee69ce64eb216d1b0d9"
}
},
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-dev-menu",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "fd6ead988a9fee469abf2959ccbe71769fd6edea"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-dev-menu",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "cdaa843725c7c9dc594a3824554cbc536488153b"
}
},
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-gl",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "0a97bfb56b26ec5169bbdb84ca43fbf09ea261e9"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-gl",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "2e891b6e04fdf18879dc2244d62282a18e757dc3"
}
},
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoAutolinkingIos"
],
"hash": "bfcbddee800922ae0b731bcb96c052deeb56eab2"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoAutolinkingIos"
],
"hash": "1956f1cc06a8e1a29efb1492aea72907146b642e"
}
},
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-modules-jsi/apple",
"reasons": [
"expoAutolinkingIos"
],
"hash": "0e24945cd7bda46039f5bb22a1de48150bd10c13"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-modules-jsi/apple",
"reasons": [
"expoAutolinkingIos"
],
"hash": "17d5d1fc0c138b72629895f35d9de65cf1347bcf"
}
},
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "node_modules/@shopify/react-native-skia",
"reasons": [
"rncoreAutolinkingAndroid"
],
"hash": "4504c1f47440ab77923c2231edf8b06899578cdc"
},
"afterSource": {
"type": "dir",
"filePath": "node_modules/@shopify/react-native-skia",
"reasons": [
"rncoreAutolinkingAndroid"
],
"hash": "3f9e1aacb7f75a36f2668ba943381096ba26eac4"
}
}
]Generated by PR labeler 🤖 |
9a667e3 to
550f9c9
Compare
Contributor
|
Subscribed to pull request
Generated by CodeMention |
tsapeta
reviewed
Jun 1, 2026
tsapeta
requested changes
Jun 1, 2026
tsapeta
reviewed
Jun 2, 2026
4731ba8 to
6840dba
Compare
tsapeta
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Native-backed
ArrayBuffers were copied when passed back to native functions expectingNativeArrayBuffer. React Native 0.86 now added an API to expose the original mutable backing buffer (see facebook/react-native#56156). This avoids unnecessary copies while preserving the existing copy behavior for JS-allocated buffers.How
tryGetMutableBuffer()/tryBorrowMutableBuffer()to borrow native-backedArrayBuffermemory and retain the underlyingMutableBufferfor the lifetime of the native wrapper.byteOffsetTest Plan
Added tests to verify native-backed sharing and copy fallback behavior:
Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).