Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/request.js
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,14 @@ req.acceptsLanguages = function(...languages) {
* @param {object} [options]
* @param {boolean} [options.combine=false]
* @return {number|array}
* @throws {TypeError}
* @public
*/

req.range = function range(size, options) {
if (!Number.isInteger(size) || size < 0) {
throw new TypeError('size must be a non-negative integer to req.range');
}
var range = this.get('Range');
if (!range) return;
return parseRange(size, range, options);
Expand Down
55 changes: 55 additions & 0 deletions test/req.range.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,61 @@ describe('req', function(){
.expect(200, '[{"start":0,"end":74}]', done)
})

it('should throw TypeError for invalid size', function () {
var app = express();

app.use(function (req, res) {
try {
req.range(-1);
} catch (err) {
res.status(500).send(err.name + ': ' + err.message);
return;
}
res.send('no error');
});

return request(app)
.get('/')
.set('Range', 'bytes=0-10')
.expect(500)
.expect(/TypeError: size must be a non-negative integer to req\.range/);
});

it('should throw TypeError for various invalid size types', function () {
var app = express();
var testCases = [
{ value: 'string', label: 'string' },
{ value: {}, label: 'object' },
{ value: [], label: 'array' },
{ value: null, label: 'null' },
{ value: undefined, label: 'undefined' },
{ value: 1.5, label: 'float' },
{ value: NaN, label: 'NaN' },
{ value: Infinity, label: 'Infinity' }
];

app.use(function (req, res) {
var type = req.query.type;
var value = testCases.find(c => c.label === type).value;

try {
req.range(value);
res.send('no error');
} catch (err) {
res.status(500).send(err.name + ': ' + err.message);
}
});

// Run all tests in sequence
return Promise.all(testCases.map(function (testCase) {
return request(app)
.get('/?type=' + testCase.label)
.set('Range', 'bytes=0-10')
.expect(500)
.expect(/TypeError: size must be a non-negative integer to req\.range/);
}));
});

it('should have a .type', function (done) {
var app = express()

Expand Down