Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Readme.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here are already being handled by #6601

Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@

**Fast, unopinionated, minimalist web framework for [Node.js](https://nodejs.org).**

**This project has a [Code of Conduct][].**

**This project has a [Code of Conduct]
## Table of contents

- [Table of contents](#table-of-contents)
Expand Down Expand Up @@ -148,7 +147,9 @@ The Express.js project welcomes all constructive contributions. Contributions ta
from code for bug fixes and enhancements, to additions and fixes to documentation, additional
tests, triaging incoming pull requests and issues, and more!

See the [Contributing Guide](https://github.com/expressjs/.github/blob/HEAD/CONTRIBUTING.yml) for more technical details on contributing.
See the [Contributing Guide](./Contributing.md) for more technical details on contributing.

See the [Contributing Guide] for more technical details on contributing.

### Security Issues

Expand Down Expand Up @@ -269,4 +270,5 @@ The original author of Express is [TJ Holowaychuk](https://github.com/tj)
[npm-version-image]: https://badgen.net/npm/v/express
[ossf-scorecard-badge]: https://api.scorecard.dev/projects/github.com/expressjs/express/badge
[ossf-scorecard-visualizer]: https://ossf.github.io/scorecard-visualizer/#/projects/github.com/expressjs/express
[Code of Conduct]: https://github.com/expressjs/express/blob/master/Code-Of-Conduct.md
[Code of Conduct]: https://github.com/expressjs/.github/blob/HEAD/CODE_OF_CONDUCT.md
[Contributing Guide]: https://github.com/expressjs/express/blob/master/Contributing.md
50 changes: 42 additions & 8 deletions package.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the PR focused, this change is unnecessary

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if you created a new PR, since this change could block the goal of the current one, which is to bring that file back.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaginiSharma01 This change is still here. Please remove the changes you made here, they don't belong in this PR

Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,40 @@
"version": "5.1.0",
"author": "TJ Holowaychuk <[email protected]>",
"contributors": [
"Aaron Heckmann <[email protected]>",
"Ciaran Jessup <[email protected]>",
"Douglas Christopher Wilson <[email protected]>",
"Guillermo Rauch <[email protected]>",
"Jonathan Ong <[email protected]>",
"Roman Shtylman <[email protected]>",
"Young Jae Sim <[email protected]>"
{
"name": "Aaron Heckmann",
"email": "[email protected]"
},
{
"name": "Ciaran Jessup",
"email": "[email protected]"
},
{
"name": "Douglas Christopher Wilson",
"email": "[email protected]"
},
{
"name": "Guillermo Rauch",
"email": "[email protected]"
},
{
"name": "Jonathan Ong",
"email": "[email protected]"
},
{
"name": "Roman Shtylman",
"email": "[email protected]"
},
{
"name": "Young Jae Sim",
"email": "[email protected]"
}
],
"license": "MIT",
"repository": "expressjs/express",
"repository": {
"type": "git",
"url": "git+https://github.com/expressjs/express.git"
},
"homepage": "https://expressjs.com/",
"funding": {
"type": "opencollective",
Expand Down Expand Up @@ -94,5 +118,15 @@
"test-ci": "nyc --exclude examples --exclude test --exclude benchmarks --reporter=lcovonly --reporter=text npm test",
"test-cov": "nyc --exclude examples --exclude test --exclude benchmarks --reporter=html --reporter=text npm test",
"test-tap": "mocha --require test/support/env --reporter tap --check-leaks test/ test/acceptance/"
},
"main": "index.js",
"directories": {
"example": "examples",
"lib": "lib",
"test": "test"
},
"type": "commonjs",
"bugs": {
"url": "https://github.com/expressjs/express/issues"
}
}