Skip to content

Conversation

tausiq2003
Copy link

Added block readme github action to block spam readme prs. Seeing it from a very long time spam pullrequests have been made and closed.
Thanks.

Added block readme github action to block spam readme prs.
Thanks
Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, I don’t think we should have this.

@tausiq2003
Copy link
Author

tausiq2003 commented Oct 4, 2025

Thanks for your contribution, I don’t think we should have this.

I have added the github.event.pull_request.author_association which ensures only members, owner and collaborators to change the readme.

@evenstensberg
Copy link

@bjohansebas you should probably have something in place to close these prs, it might seem unneeded but it accumulates to a lot of lost time in the long term, which people exploit.

@bjohansebas
Copy link
Member

This has been a team decision for a long time not to have something like this (#5449 (comment)). Probably the best solution so far would be to use github/ai-moderator (I just remembered that this action exists, which would be the way to move forward with this PR and that way the team could consider accepting it.). I still doubt its effectiveness, but I wouldn’t mind trying it. The PR spam will keep happening until that YouTube tutorial gets taken down, but it seems like that will never happen.

example: https://github.com/nodejs/help/blob/main/.github/workflows/spam-detect.yml

cc: @expressjs/triagers @expressjs/express-tc

File name was wrong its Readme, I did README
-Now closes PR
Added issues true, hoping it to close the pr
@tausiq2003
Copy link
Author

This has been a team decision for a long time not to have something like this (#5449 (comment)). Probably the best solution so far would be to use github/ai-moderator (I just remembered that this action exists, which would be the way to move forward with this PR and that way the team could consider accepting it.). I still doubt its effectiveness, but I wouldn’t mind trying it. The PR spam will keep happening until that YouTube tutorial gets taken down, but it seems like that will never happen.

example: https://github.com/nodejs/help/blob/main/.github/workflows/spam-detect.yml

cc: @expressjs/triagers @expressjs/express-tc

I also thought to add ai thing here, but the thing is that first thing, ai could make mistakes, second thing, running a github action on a public repo doesn't cost money, while running a github model could cost money source, third why you want a third party (ai model) to read your whole repo, if we have code spam (promotional links) in the whole repo in diff files then it could have make sense, but it seems that the instructor on youtube told her "dear" students to spam on readme. And its just one file, readme could contain typos, which is acceptable in general, and i also added the permissions (only specific person with roles can change the pr), so most folks who got instructed are changing the readme file only so i have added wc -l to check what files have been changed if its one and equals to Readme.md it will auto close, believing in the fact that MOST contributor(first time contributors) changing only readme and adding unneccessary change that means if we merge this pr anyone can't change the readme.md file only people with certain roles can change it. Adding AI is good, but why to integrate a third party tool if its a simple github-action. Also tested here tausiq2003#7,
haven't tested using certain rules. @evenstensberg now it auto closes the pr too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants