Skip to content

chore: refactor footer and header icons #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 24 commits into
base: gh-pages
Choose a base branch
from
Open

chore: refactor footer and header icons #1962

wants to merge 24 commits into from
+198 −156

Conversation

ShubhamOulkar
Copy link
Member

@ShubhamOulkar ShubhamOulkar commented Jul 5, 2025 •
edited
Loading

  • Implement theme toggle button with modern mask-image
  • Add dynamic theme support using --box-fg for theme toggle button
  • Replace dual logo images with single background-image for OpenJS Foundation logo
  • Implement automatic logo toggle based on .dark-mode
  • Remove Font Awesome dependency
  • Replace icons with optimized local SVG
  • Clean up redundant SVGs (remove duplicates or unused icons)
  • fix bugs and refactor theme.js

~6 KB reduction in CSS payload

image

@ShubhamOulkar ShubhamOulkar requested a review from a team as a code owner July 5, 2025 13:58
@netlify Netlify
Copy link

netlify bot commented Jul 5, 2025 •
edited
Loading

✅ Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 2248f8b
🔍 Latest deploy log https://app.netlify.com/projects/expressjscom-preview/deploys/687db393d2b5f60008de26fb
😎 Deploy Preview https://deploy-preview-1962--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ShubhamOulkar ShubhamOulkar marked this pull request as draft July 5, 2025 13:59
@ShubhamOulkar ShubhamOulkar changed the title refactor footer chore: refactor footer and header icons Jul 5, 2025
@ShubhamOulkar ShubhamOulkar added the maintenance Issues/PRs related to making the website maintainable label Jul 5, 2025
ShubhamOulkar
ShubhamOulkar commented Jul 5, 2025
View reviewed changes
ShubhamOulkar
ShubhamOulkar commented Jul 5, 2025
View reviewed changes
@ShubhamOulkar ShubhamOulkar mentioned this pull request Jul 6, 2025
Open
10 tasks
@ShubhamOulkar ShubhamOulkar marked this pull request as ready for review July 6, 2025 07:08
bjohansebas
bjohansebas reviewed Jul 11, 2025
View reviewed changes
bjohansebas
bjohansebas reviewed Jul 11, 2025
View reviewed changes
bjohansebas
bjohansebas reviewed Jul 11, 2025
View reviewed changes
bjohansebas
bjohansebas reviewed Jul 11, 2025
View reviewed changes
@bjohansebas bjohansebas mentioned this pull request Jul 11, 2025
Closed
bjohansebas
bjohansebas reviewed Jul 11, 2025
View reviewed changes
@ShubhamOulkar ShubhamOulkar self-assigned this Jul 19, 2025
@ShubhamOulkar
Copy link
Member Author

Hi @bjohansebas, Can you review this? I want to land this early as possible.🙏

bjohansebas
bjohansebas reviewed Jul 19, 2025
View reviewed changes
@crandmck crandmck self-requested a review July 21, 2025 14:46
crandmck
crandmck approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@crandmck crandmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I didn't test it comprehensively.
I trust @bjohansebas and others will do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crandmck crandmck crandmck approved these changes

@bjohansebas bjohansebas Awaiting requested review from bjohansebas

Assignees

@ShubhamOulkar ShubhamOulkar

Labels
maintenance Issues/PRs related to making the website maintainable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShubhamOulkar @crandmck @bjohansebas