Skip to content

chore: remove jquery #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

ShubhamOulkar
Copy link
Member

@ShubhamOulkar ShubhamOulkar commented Jul 6, 2025

Vanilla JS written for following components

  • scroll to top of the page
  • Display current selected language in language picker component
  • Page of content left sidebar tracker with respective headings
  • i18n notice

closes #1590

@ShubhamOulkar ShubhamOulkar requested a review from a team as a code owner July 6, 2025 10:07
Copy link

netlify bot commented Jul 6, 2025

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 47bf6fc
🔍 Latest deploy log https://app.netlify.com/projects/expressjscom-preview/deploys/686a4eccaf06120008c49e65
😎 Deploy Preview https://deploy-preview-1964--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ShubhamOulkar ShubhamOulkar marked this pull request as draft July 6, 2025 10:08

.scroll #top {
body.scroll #top {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not finalised. I added to make sure that class only applied to body, since I am changing pre written JS and without typos 😁. I will remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactoring from jQuery to modern JavaScript
2 participants