Skip to content

Conversation

@efekrskl
Copy link
Contributor

Towards #1100

My initial goal was to come up with a workflow, but the outcome was not really reliable. Considering the efforts at #1787 it's probably time not so well spent. So I'd fix some of the broken links instead

@efekrskl efekrskl requested a review from a team as a code owner October 19, 2025 09:22
@netlify
Copy link

netlify bot commented Oct 19, 2025

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit f9db830
🔍 Latest deploy log https://app.netlify.com/projects/expressjscom-preview/deploys/68fd440186665d0008534357
😎 Deploy Preview https://deploy-preview-2082--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2025

🚦 Lighthouse Results (Mobile & Desktop)

URL Device Perf A11y Best Practices
/ mobile 🔴 70 🟢 100 🟢 96
/en/blog/posts.html mobile 🟢 92 🟢 96 🟢 96
/en/5x/api.html mobile 🔴 71 🟢 95 🟢 96
/ desktop 🟢 100 🟢 100 🟢 96
/en/blog/posts.html desktop 🟢 99 🟢 96 🟢 92
/en/5x/api.html desktop 🟢 100 🟢 95 🟢 96


- [jshttp](https://jshttp.github.io/) modules providing useful utility functions; see [Utility modules](/{{ page.lang }}/resources/utils.html).
- [jshttp](https://github.com/jshttp) modules providing useful utility functions; see [Utility modules](/{{ page.lang }}/resources/utils.html).
- [pillarjs](https://pillarjs.github.io/): low-level modules that Express uses internally.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [pillarjs](https://pillarjs.github.io/): low-level modules that Express uses internally.
- [pillarjs](https://github.com/pillarjs): low-level modules that Express uses internally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks like github.io page is no longer maintained. I replaced all pillarjs links, thanks!

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, note that it’s not necessary to change it for the other languages; when Crowdin brings in the changes, the corresponding updates will be made in the respective language

@bjohansebas bjohansebas added docs Issues/pr concerning content i18n labels Oct 25, 2025
@bjohansebas bjohansebas merged commit 738f860 into expressjs:gh-pages Oct 25, 2025
12 checks passed
@efekrskl
Copy link
Contributor Author

LGTM, note that it’s not necessary to change it for the other languages; when Crowdin brings in the changes, the corresponding updates will be made in the respective language

Ah, thanks for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Issues/pr concerning content i18n

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants