Skip to content

Added fallback method for check_label CI#347

Open
kp-shawn-thiah wants to merge 1 commit intomainfrom
fix-check-label-ci
Open

Added fallback method for check_label CI#347
kp-shawn-thiah wants to merge 1 commit intomainfrom
fix-check-label-ci

Conversation

@kp-shawn-thiah
Copy link
Contributor

@kp-shawn-thiah kp-shawn-thiah commented Mar 16, 2026 •
edited
Loading

On push events like rebase merges to main, gh-find-current-pr sometimes fails to resolve the PR due to github's commit-to-PR indexing delay.

We will introduce polling to wait for the indexing and then get the PR issue number.

@kp-shawn-thiah kp-shawn-thiah requested a review from a team as a code owner March 16, 2026 09:23
@kp-shawn-thiah kp-shawn-thiah added the ignore-release Ignore the Release GitHub Action label Mar 16, 2026
@github-actions
Copy link

github-actions bot commented Mar 16, 2026 •
edited
Loading

🚀 Release Plan

🏷️ Release skipped — ignore-release label is applied.

@github-actions
Copy link

github-actions bot commented Mar 16, 2026 •
edited
Loading

Code coverage summary for 2c5df73:

Filename                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
wolfssl-sys/src/lib.rs                    34                 0   100.00%           4                 0   100.00%          22                 0   100.00%           0                 0         -
wolfssl/src/aes256.rs                    166                 8    95.18%          11                 0   100.00%         124                 4    96.77%           0                 0         -
wolfssl/src/chacha20_poly1305.rs          75                 2    97.33%           5                 0   100.00%          66                 2    96.97%           0                 0         -
wolfssl/src/context.rs                   401               173    56.86%          41                14    65.85%         286               110    61.54%           0                 0         -
wolfssl/src/error.rs                      44                12    72.73%           5                 1    80.00%          43                10    76.74%           0                 0         -
wolfssl/src/lib.rs                        81                15    81.48%          11                 1    90.91%          72                13    81.94%           0                 0         -
wolfssl/src/rng.rs                        71                 9    87.32%           6                 0   100.00%          42                 3    92.86%           0                 0         -
wolfssl/src/ssl.rs                      1233               320    74.05%          85                25    70.59%         834               241    71.10%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                   2105               539    74.39%         168                41    75.60%        1489               383    74.28%           0                 0         -

✅ Region coverage 74% passes
✅ Line coverage 74% passes

@kp-shawn-thiah kp-shawn-thiah marked this pull request as draft March 16, 2026 12:31
@kp-shawn-thiah kp-shawn-thiah marked this pull request as ready for review March 17, 2026 03:27
@kp-shawn-thiah
ci: add polling to retrieve PR issue number
50a7b86 
Currently Github API has a delay when indexing commit-to-PR association,
which causes the CI to fail because it cannot get the PR issue number
from the commit when a merge rebase comes in. Hence the polling will add
a delay to allow us to get PR issue number after indexing has completed.

Here are some resources that suggests this same issue:
  - jwalton/gh-find-current-pr#42
  - python/the-knights-who-say-ni#86
  - https://github.com/orgs/community/discussions/51962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ignore-release Ignore the Release GitHub Action

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kp-shawn-thiah