-
-
Notifications
You must be signed in to change notification settings - Fork 79
feat(functions): CachedCallable and raw functions #310 #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
aea34a4 to
2bad259
Compare
ptondereau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly good from my point of view! Thank you for this PR
2bad259 to
554ada5
Compare
ptondereau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you!
3635d35 to
f04e58a
Compare
Pull Request Test Coverage Report for Build 20554631838Details
💛 - Coveralls |
Xenira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use platform independent benchmarks from #602 for this
f04e58a to
0f710b4
Compare
1968630 to
0463de8
Compare
0463de8 to
62aebf4
Compare
|
@kakserpom I will try to have all benchmarks in #602 to get a baseline. Another thing we might want to consider is having the plain callable initialize the function info cach lazily to have it perform better as well. Not sure if we should just merge those two and have the option to set it to lazy / eager / no caching. |
Implements #310