Skip to content

Conversation

@kakserpom
Copy link
Contributor

Implements #310

@kakserpom kakserpom force-pushed the 310_performance branch 4 times, most recently from aea34a4 to 2bad259 Compare December 20, 2025 18:42
Copy link
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly good from my point of view! Thank you for this PR

ptondereau
ptondereau previously approved these changes Dec 21, 2025
Copy link
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@kakserpom kakserpom force-pushed the 310_performance branch 2 times, most recently from 3635d35 to f04e58a Compare December 21, 2025 14:46
@coveralls
Copy link

coveralls commented Dec 21, 2025

Pull Request Test Coverage Report for Build 20554631838

Details

  • 96 of 139 (69.06%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.7%) to 37.686%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/args.rs 37 38 97.37%
benches/function_call.rs 0 6 0.0%
src/types/callable.rs 52 58 89.66%
crates/macros/src/function.rs 0 30 0.0%
Totals Coverage Status
Change from base Build 20553343606: 1.7%
Covered Lines: 1948
Relevant Lines: 5169

💛 - Coveralls

Copy link
Member

@Xenira Xenira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use platform independent benchmarks from #602 for this

@kakserpom
Copy link
Contributor Author

Should use platform independent benchmarks from #602 for this

Well #602 is still in the works, you can merge this one and then replace the benchmarks with yours in #602 or you can merge #602 first...

@kakserpom kakserpom force-pushed the 310_performance branch 2 times, most recently from 1968630 to 0463de8 Compare December 28, 2025 13:37
@Xenira
Copy link
Member

Xenira commented Dec 28, 2025

@kakserpom I will try to have all benchmarks in #602 to get a baseline.

Another thing we might want to consider is having the plain callable initialize the function info cach lazily to have it perform better as well. Not sure if we should just merge those two and have the option to set it to lazy / eager / no caching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants