Skip to content

Conversation

@kakserpom
Copy link
Contributor

Fixes #375

@coveralls
Copy link

coveralls commented Dec 22, 2025

Pull Request Test Coverage Report for Build 20547658374

Details

  • 1 of 56 (1.79%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 35.968%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/types/array/mod.rs 1 2 50.0%
src/zend/handlers.rs 0 54 0.0%
Files with Coverage Reduction New Missed Lines %
src/zend/handlers.rs 1 0.0%
Totals Coverage Status
Change from base Build 20542278985: -0.4%
Covered Lines: 1811
Relevant Lines: 5035

💛 - Coveralls

@kakserpom kakserpom force-pushed the fix_prop_visibility branch 3 times, most recently from a5bc458 to 7924840 Compare December 22, 2025 15:46
@kakserpom kakserpom changed the title fix: property visibility checks #375 fix(class): property visibility checks #375 Dec 22, 2025
Copy link
Member

@Xenira Xenira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you remove the unrelated docblock changes from this PR?

@kakserpom

This comment was marked as outdated.

@kakserpom kakserpom force-pushed the fix_prop_visibility branch 2 times, most recently from ef3ffbf to d8139f3 Compare December 27, 2025 18:12
@kakserpom kakserpom requested a review from Xenira December 27, 2025 18:13
@Xenira
Copy link
Member

Xenira commented Dec 27, 2025

rustfmt did that. Is that a problem?

Just to make history cleaner and prevent conflicts. Not a big thing, and usually fine. Just saw a lot of those changes in your PRs and in that case its better to do one PR containing all rustfmt changes.

@kakserpom kakserpom requested a review from Xenira December 28, 2025 02:49
@Xenira Xenira enabled auto-merge (squash) December 28, 2025 11:48
@Xenira Xenira merged commit 32b0dd6 into extphprs:master Dec 28, 2025
126 of 127 checks passed
@Xenira Xenira mentioned this pull request Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visibility not respected in read_property and write_property

3 participants